Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go for 3.5: 1.15.x -> 1.16.3 #12874

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Update go for 3.5: 1.15.x -> 1.16.3 #12874

merged 1 commit into from
Apr 19, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Apr 17, 2021

Fixes #12732

@ptabor ptabor added this to the etcd-v3.5 milestone Apr 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #12874 (467a94c) into master (80586c5) will decrease coverage by 20.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12874       +/-   ##
===========================================
- Coverage   71.99%   51.49%   -20.50%     
===========================================
  Files         427      424        -3     
  Lines       33813    33758       -55     
===========================================
- Hits        24342    17385     -6957     
- Misses       7519    14437     +6918     
+ Partials     1952     1936       -16
Flag Coverage Δ
all 51.49% <ø> (-20.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/v3/ordering/util.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/logutil/zap.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/types/slice.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/tlsutil/cipher_suites.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/sockopt_unix.go 0.00% <0.00%> (-100.00%) ⬇️
client/v3/naming/endpoints/endpoints.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/timeout_dialer.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/timeout_listener.go 0.00% <0.00%> (-100.00%) ⬇️
...er/proxy/grpcproxy/adapter/watch_client_adapter.go 7.14% <0.00%> (-92.86%) ⬇️
client/pkg/v3/transport/keepalive_listener.go 0.00% <0.00%> (-92.31%) ⬇️
... and 216 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80586c5...467a94c. Read the comment docs.

spzala
spzala reviewed Apr 17, 2021
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one comment - we should update the reference here as well https://github.com/etcd-io/etcd#getting-etcd Thanks @ptabor

@ptabor
Copy link
Contributor Author

ptabor commented Apr 19, 2021

Thank you @spzala. Fixed.

@ptabor ptabor merged commit 11249fd into etcd-io:master Apr 19, 2021
@ptabor ptabor deleted the 20210417-go1.16.3 branch April 19, 2021 14:51
@spzala
Copy link
Member

spzala commented Apr 20, 2021

Thank you @spzala. Fixed.

Thank you @ptabor !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala left review comments

Assignees
No one assigned
Labels
None yet
Milestone
etcd-v3.5
Development

Successfully merging this pull request may close these issues.

Use Go 1.16 for 3.5 release and testing
3 participants
@ptabor @codecov-commenter @spzala